Repository navigation
release: v0.123 rc.11 blocker bundle (#1809, #1814, #1815, #1816, #1817) - #1818
Conversation
Since #1748 receipts only carry CreatedTransaction. genlayer-js before v2 only parses NewTransaction, so it throws "Transaction not processed by consensus" for a transaction Studio did process, and the caller never gets the txId. GENLAYER_STUDIO_LEGACY_NEW_TRANSACTION_RECEIPT_LOG (default off) adds the legacy log after CreatedTransaction, so a Studio can be upgraded before its clients migrate. These SDKs also need gasless mode, since they send no fees. The default keeps the receipt faithful to CreationPhase. Validated with an in-place upgrade from v0.121.25 on rc.10 images with fees off, using genlayer-js 0.20.3 and 0.18.9.
Forward-port the RPC threadpool part of #1766 (2004fc4) to v0.123: sync JSON-RPC handlers run in the threadpool, async endpoints load contract snapshots and ConsensusData queries in workers, and worker notifications are published on the app loop via call_soon_threadsafe. The validator registry read handlers stay on the loop because they use the validators manager's shared long-lived session.
A sim_config.genvm_datetime before 2026-01-01 made the manager drop the v0.2 line (studio network fork in genvm-chainforks.json, v0.6.0-rc11), so every run of a pinned contract or a '# v0.2.x' deploy was refused before start: gen_call errors, and consensus retried until cancel while counting GenVM failures toward the worker health threshold. Clamp such runs to the fork activation time.
/genvm-cache is a node-wide hostPath shared by every Studio release on the node, and GenVM keys precompiled modules only by runner hash. v0.121 (v0.2.16) and v0.123 (v0.2.17, v0.3.x) wrote into the same pc/ tree, so v0.2 calls could load modules built by another executor and time out. Point each executor's cache_dir at /genvm-cache/<executor-version>/, keep the precompile marker inside each per-version dir, and leave the legacy shared pc/ tree untouched for older Studios. Bump the CI precompile cache key so old-layout caches are not restored.
…d queue order backfills c1d2e3f4a5b6 sets SET LOCAL statement_timeout = '30s' and env.py runs the whole chain in one transaction, so e4f6a8c0d2b4 and f5a7c9e1b3d5 inherited the limit and were cancelled on prod-sized data, rolling back the upgrade. Reset statement_timeout to 0 at the start of both upgrades; lock_timeout and the single-transaction behaviour are unchanged.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
fund_account committed the PENDING faucet SEND (value_credited=false) before credit_tx_value_once ran. A consensus worker could claim it in that gap; execute_transfer's unlocked value_credited read then credited the recipient a second time once the endpoint committed (balance 2000 for a 1000 fund, seen in the rc11 bundle's integration run). The race predates the threadpool change, which can widen the window. Insert with commit=False so the row only becomes visible already credited. The worker-side guard in execute_transfer is still a plain read; making it a compare-and-set is left for a follow-up.
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
Precompiled GenVM modules carry the CPU features of the host that built
them. The cache key only had OS and arch, so a cache saved on an AVX-512
runner was restored on one without avx512bitalg. GenVM then rejected every
module ("compilation setting has_avx512bitalg is enabled, but not available
on the host"), recompiled in memory on each run, and the first legacy v0.2
schema call hit GENVM_TIMEOUT at 30s (rc11 bundle run 42737821857, suite
52m vs 33m). The arch-only entrypoint marker still said "already
precompiled", so nothing re-precompiled.
Add a hash of the /proc/cpuinfo flags to the key so each runner CPU type
gets its own cache entry.
…cache into release/v0.123-rc11
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
Delivery context
Landing cut for the Studio v0.123 rc.11 release blockers. Each change is reviewed in its own PR against
v0.123-dev; this branch merges all of them so one full E2E run covers the whole set. After it lands,v0.123.0-rc.11is cut fromv0.123-dev.Included (frozen heads):
NewTransactionreceipt log for pre-v2 SDKs (Rally, CM)eb8fe3d5statement_timeoutin migrations e4f6/f5a7a5a84da4cache_dir(hostPath shared across Studios)78684ca07cf3fd13genvm_datetimepredates the studio v0.2 forkbd946da2Excluded on purpose:
fix/v0123-transient-transport-fatalkept for v0.123.1.New work goes above this cut; changing any head above requires a new E2E run.
Problem and outcome
Studio v0.123.0 ships to studio-prd, rally-studio-prd/stg and Collective Memory on Fri 13 Nov 2026. These are the code blockers found while preparing that release; details, tests and risks are in each PR.
Implementation and validation
--no-ff, no conflicts (endpoints.pyauto-merged between fix(rpc): add opt-in NewTransaction receipt log for pre-v2 SDKs #1809 and fix(rpc): run sync RPC handlers and snapshot loads off the event loop #1815).test_studio_fees.py::test_leader_timeout_appeal_uses_next_normal_fee_scheduledeselected: it fails identically onv0.123-dev(e735553).genvm-runtimestage built with rc11, per-version dirs confirmed, two-boot precompile test.Merge with squash or merge commit; then close the five feeder PRs as landed through this one.